2.1.x bugfix branch updated

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

2.1.x bugfix branch updated

goldsimon@gmx.de
Hi all,

the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
This means I'd like to release 2.1.3 shortly. Please test :-)

[1] http://git.savannah.nongnu.org/cgit/lwip.git/log/?h=STABLE-2_1_x

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

goldsimon@gmx.de
Axel Lin wrote:

> Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> >
> > Hi all,
> >
> > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > This means I'd like to release 2.1.3 shortly. Please test :-)
>
> Hi Simon,
> Is below commit also required for stable-2.1.x?
> http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> It was reported on
> http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html

Yes. I've cherry-picked that one also. Plus an updated fix for this.

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

goldsimon@gmx.de
In reply to this post by goldsimon@gmx.de
Jacob Kroon wrote:

> Hi Simon,
>
> On Mon, Feb 18, 2019 at 1:51 PM Simon Goldschmidt <[hidden email]> wrote:
> >
> > Hi all,
> >
> > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > This means I'd like to release 2.1.3 shortly. Please test :-)
> >
>
> Any chance you can cherry-pick the PPPOE_SCNAME_SUPPORT fixes to the
> upcoming 2.1.3 ?
> See further discussion here:
> http://lists.nongnu.org/archive/html/lwip-devel/2018-12/msg00040.html

I've just cherry-picked four PPP patches. Could you check if these are enough?

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

Jacob Kroon
On Tue, Feb 26, 2019 at 4:50 PM Simon Goldschmidt <[hidden email]> wrote:

>
> Jacob Kroon wrote:
> > Hi Simon,
> >
> > On Mon, Feb 18, 2019 at 1:51 PM Simon Goldschmidt <[hidden email]> wrote:
> > >
> > > Hi all,
> > >
> > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > >
> >
> > Any chance you can cherry-pick the PPPOE_SCNAME_SUPPORT fixes to the
> > upcoming 2.1.3 ?
> > See further discussion here:
> > http://lists.nongnu.org/archive/html/lwip-devel/2018-12/msg00040.html
>
> I've just cherry-picked four PPP patches. Could you check if these are enough?
>

Yes, that looks correct.
Thanks
/Jacob

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

Axel Lin
In reply to this post by goldsimon@gmx.de
Simon Goldschmidt <[hidden email]> 於 2019年2月26日 週二 下午11:48寫道:

>
> Axel Lin wrote:
> > Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> > >
> > > Hi all,
> > >
> > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > This means I'd like to release 2.1.3 shortly. Please test :-)
> >
> > Hi Simon,
> > Is below commit also required for stable-2.1.x?
> > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > It was reported on
> > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
>
> Yes. I've cherry-picked that one also. Plus an updated fix for this.
Hi Simon,
Now I got below build issue in both master and stable-2.1.x branch:

../../../../src/core/udp.c: In function ‘udp_bind’:
../../../../src/core/udp.c:999:42: error: suggest parentheses around
‘&&’ within ‘||’ [-Werror=parentheses]
           if ((ipcb->local_port == port) &&
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
               ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               /* IP address matches or any IP used? */
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               ip_addr_isany(ipaddr) ||
               ~~~~~~~~~~~~~~~~~~~~~~~~
               ip_addr_isany(&ipcb->local_ip))) ||
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
recipe for target 'udp.o' failed
make: *** [udp.o] Error 1

Regards,
Axel

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

Jacob Kroon
On Wed, Feb 27, 2019 at 1:45 AM Axel Lin <[hidden email]> wrote:

>
> Simon Goldschmidt <[hidden email]> 於 2019年2月26日 週二 下午11:48寫道:
> >
> > Axel Lin wrote:
> > > Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> > > >
> > > > Hi all,
> > > >
> > > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > >
> > > Hi Simon,
> > > Is below commit also required for stable-2.1.x?
> > > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > > It was reported on
> > > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
> >
> > Yes. I've cherry-picked that one also. Plus an updated fix for this.
> Hi Simon,
> Now I got below build issue in both master and stable-2.1.x branch:
>
> ../../../../src/core/udp.c: In function ‘udp_bind’:
> ../../../../src/core/udp.c:999:42: error: suggest parentheses around
> ‘&&’ within ‘||’ [-Werror=parentheses]
>            if ((ipcb->local_port == port) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>                ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                /* IP address matches or any IP used? */
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(&ipcb->local_ip))) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> /home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
> recipe for target 'udp.o' failed
> make: *** [udp.o] Error 1
>

I see the same build error using stable-2.1.x branch. I also get
another build error:

api_lib.c:274:78: error: macro "LWIP_PLATFORM_DIAG" requires 2
arguments, but only 1 given

Reverting commit 174cc87227dedf69f7d4aaf0fb6aad4c31408983 seems to
make the problem go away, but it might be our macros that are bad.

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

goldsimon@gmx.de
Jacob Kroon wrote:

> On Wed, Feb 27, 2019 at 1:45 AM Axel Lin <[hidden email]> wrote:
> >
> > Simon Goldschmidt <[hidden email]> 於 2019年2月26日 週二 下午11:48寫道:
> > >
> > > Axel Lin wrote:
> > > > Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> > > > >
> > > > > Hi all,
> > > > >
> > > > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > > >
> > > > Hi Simon,
> > > > Is below commit also required for stable-2.1.x?
> > > > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > > > It was reported on
> > > > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
> > >
> > > Yes. I've cherry-picked that one also. Plus an updated fix for this.
> > Hi Simon,
> > Now I got below build issue in both master and stable-2.1.x branch:
> >
> > ../../../../src/core/udp.c: In function ‘udp_bind’:
> > ../../../../src/core/udp.c:999:42: error: suggest parentheses around
> > ‘&&’ within ‘||’ [-Werror=parentheses]
> >            if ((ipcb->local_port == port) &&
> >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> >                ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
> >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >                /* IP address matches or any IP used? */
> >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >                (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
> >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >                ip_addr_isany(ipaddr) ||
> >                ~~~~~~~~~~~~~~~~~~~~~~~~
> >                ip_addr_isany(&ipcb->local_ip))) ||
> >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > /home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
> > recipe for target 'udp.o' failed
> > make: *** [udp.o] Error 1
> >
>
> I see the same build error using stable-2.1.x branch. I also get
> another build error:
>
> api_lib.c:274:78: error: macro "LWIP_PLATFORM_DIAG" requires 2
> arguments, but only 1 given
>
> Reverting commit 174cc87227dedf69f7d4aaf0fb6aad4c31408983 seems to
> make the problem go away, but it might be our macros that are bad.

Yes, it's your macro. LWIP_PLATFORM_DIAG takes 1 argument, not two.
Probably you haven't yet compiled code that uses this macro?

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

goldsimon@gmx.de
In reply to this post by Axel Lin
Axel Lin wrote:

> Simon Goldschmidt <[hidden email]> 於 2019年2月26日 週二 下午11:48寫道:
> >
> > Axel Lin wrote:
> > > Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> > > >
> > > > Hi all,
> > > >
> > > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > >
> > > Hi Simon,
> > > Is below commit also required for stable-2.1.x?
> > > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > > It was reported on
> > > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
> >
> > Yes. I've cherry-picked that one also. Plus an updated fix for this.
> Hi Simon,
> Now I got below build issue in both master and stable-2.1.x branch:
>
> ../../../../src/core/udp.c: In function ‘udp_bind’:
> ../../../../src/core/udp.c:999:42: error: suggest parentheses around
> ‘&&’ within ‘||’ [-Werror=parentheses]
>            if ((ipcb->local_port == port) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>                ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                /* IP address matches or any IP used? */
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(&ipcb->local_ip))) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> /home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
> recipe for target 'udp.o' failed
> make: *** [udp.o] Error 1

Should be fixed in master and stable branches. Thanks for reporting.

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

Jacob Kroon
In reply to this post by goldsimon@gmx.de
On Wed, Feb 27, 2019 at 10:27 AM Simon Goldschmidt <[hidden email]> wrote:

>
> Jacob Kroon wrote:
> > On Wed, Feb 27, 2019 at 1:45 AM Axel Lin <[hidden email]> wrote:
> > >
> > > Simon Goldschmidt <[hidden email]> 於 2019年2月26日 週二 下午11:48寫道:
> > > >
> > > > Axel Lin wrote:
> > > > > Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
> > > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > > > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > > > >
> > > > > Hi Simon,
> > > > > Is below commit also required for stable-2.1.x?
> > > > > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > > > > It was reported on
> > > > > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
> > > >
> > > > Yes. I've cherry-picked that one also. Plus an updated fix for this.
> > > Hi Simon,
> > > Now I got below build issue in both master and stable-2.1.x branch:
> > >
> > > ../../../../src/core/udp.c: In function ‘udp_bind’:
> > > ../../../../src/core/udp.c:999:42: error: suggest parentheses around
> > > ‘&&’ within ‘||’ [-Werror=parentheses]
> > >            if ((ipcb->local_port == port) &&
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> > >                ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >                /* IP address matches or any IP used? */
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >                (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >                ip_addr_isany(ipaddr) ||
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~
> > >                ip_addr_isany(&ipcb->local_ip))) ||
> > >                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > /home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
> > > recipe for target 'udp.o' failed
> > > make: *** [udp.o] Error 1
> > >
> >
> > I see the same build error using stable-2.1.x branch. I also get
> > another build error:
> >
> > api_lib.c:274:78: error: macro "LWIP_PLATFORM_DIAG" requires 2
> > arguments, but only 1 given
> >
> > Reverting commit 174cc87227dedf69f7d4aaf0fb6aad4c31408983 seems to
> > make the problem go away, but it might be our macros that are bad.
>
> Yes, it's your macro. LWIP_PLATFORM_DIAG takes 1 argument, not two.
> Probably you haven't yet compiled code that uses this macro?
>

Yes, all looks good after fixing our macro and updating to  latest STABLE-2_1_x.
/Jacob

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

Axel Lin
In reply to this post by goldsimon@gmx.de
Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
>
> Hi all,
>
> the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> This means I'd like to release 2.1.3 shortly. Please test :-)

Hi Simon,

The 2.1.2 was released 7 months ago and there are a bunch fixes in
current STABLE-2_1_x tree.
Just wondering if you have target date to release 2.1.3.

Regards,
Axel

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: 2.1.x bugfix branch updated

goldsimon@gmx.de
Hi Axel,

Am 28.06.2019 um 11:22 schrieb Axel Lin:

> Simon Goldschmidt <[hidden email]> 於 2019年2月18日 週一 下午8:51寫道:
>>
>> Hi all,
>>
>> the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
>> This means I'd like to release 2.1.3 shortly. Please test :-)
>
> Hi Simon,
>
> The 2.1.2 was released 7 months ago and there are a bunch fixes in
> current STABLE-2_1_x tree.
> Just wondering if you have target date to release 2.1.3.

No, no target date currently, but thanks for the hint :-)

I'll try to find the time to check for a new release.

Regards,
Simon

_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel