[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

Wilfred

URL:
  <http://savannah.nongnu.org/bugs/?18065>

                 Summary: ID in IP-Header is ZERO for all outgoing IP-packets
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Freitag 20.10.2006 um 09:15
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open

    _______________________________________________________

Details:

The reason is that int ip_output_if(), the variable ip_id (used to assign the
IDs to the packets) is not declared static. It is declare in line 386, used
for assignment in line 409 and incremented (for the next packet) in line
410.

But since it is not static, the next time ip_output_if() is called, it is set
back to 0 again, resulting in all outgoing IP-packets with ID=0.






    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18065>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

Wilfred

Follow-up Comment #1, bug #18065 (project lwip):

Hmm, likewise seems to have introduced this in ip.c 1.32. (lwIP 1_0_0) I
guess for the purpose to have separate IDs for each netif, but I'm unsure
what rfc791 says about this.

The current behavior is clearly wrong, i'll have a look at it.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18065>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

Wilfred

Follow-up Comment #2, bug #18065 (project lwip):

IP ID is essentially optional, so while this might be unintended behaviour,
it's not breaking the spec.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18065>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

Wilfred

Follow-up Comment #3, bug #18065 (project lwip):

IP ID is essentially optional, so while this might be unintended behaviour,
it's not breaking the spec.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18065>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #18065] ID in IP-Header is ZERO for all outgoing IP-packets

Wilfred

Update of bug #18065 (project lwip):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #4:

Made ip_id static again. This is required when outputting IP fragments.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18065>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel