[bug #19986] tcp connect problem

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka

URL:
  <http://savannah.nongnu.org/bugs/?19986>

                 Summary: tcp connect problem
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: phant
            Submitted on: Monday 05/28/2007 at 07:13
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

hi All:
   my lwip version is check from CVS.
   the old is ok.
   But when resolve tcp bind.producing suck problem.
   
   when tcp_connect
   pcb->sate = SYN_SENT;
   but add tcp_pcb_remove(&tcp_bound_pcbs,pcb);
   pcb->state = CLOSED.

   and assert in tcp_slowtmr();
   is it wrong,or not?

help me!




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka

Follow-up Comment #1, bug #19986 (project lwip):

I'm pretty sure this is a bug - this code was modified recently to include
the tcp_bound_pcbs list.  Hopefully it will get fixed soon.

Any volunteers?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

RE: [bug #19986] tcp connect problem

Goldschmidt Simon
> Follow-up Comment #1, bug #19986 (project lwip):
>
> I'm pretty sure this is a bug - this code was modified
> recently to include the tcp_bound_pcbs list.  Hopefully it
> will get fixed soon.
>
> Any volunteers?

Me, of course. I'm having a look at it tonight.


_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

RE: [bug #19986] tcp connect problem

Kieran Mansley
On Tue, 2007-05-29 at 10:48 +0200, Goldschmidt Simon wrote:

> > Follow-up Comment #1, bug #19986 (project lwip):
> >
> > I'm pretty sure this is a bug - this code was modified
> > recently to include the tcp_bound_pcbs list.  Hopefully it
> > will get fixed soon.
> >
> > Any volunteers?
>
> Me, of course. I'm having a look at it tonight.
>

Great, thanks.  It looks like tcp_pcb_remove() (despite its generic
sounding name) is very much tailored towards closing a connection, so we
should be using the TCP_RMV() and TCP_REG() macros for this particular
operation.

Kieran



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

RE: [bug #19986] tcp connect problem

Goldschmidt Simon

> On Tue, 2007-05-29 at 10:48 +0200, Goldschmidt Simon wrote:
> > > Follow-up Comment #1, bug #19986 (project lwip):
> > >
> > > I'm pretty sure this is a bug - this code was modified
> recently to
> > > include the tcp_bound_pcbs list.  Hopefully it will get
> fixed soon.
> > >
> > > Any volunteers?
> >
> > Me, of course. I'm having a look at it tonight.
> >
>
> Great, thanks.  It looks like tcp_pcb_remove() (despite its
> generic sounding name) is very much tailored towards closing
> a connection, so we should be using the TCP_RMV() and
> TCP_REG() macros for this particular operation.

Exactly. Fixed in CVS HEAD.


_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka
In reply to this post by Ondrej Lufinka

Update of bug #19986 (project lwip):

                  Status:                    None => Ready For Test        

    _______________________________________________________

Follow-up Comment #2:

I've checked in a fix.
Cui, could you please verify it is fixed?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka

Update of bug #19986 (project lwip):

             Assigned to:                    None => goldsimon              


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka

Follow-up Comment #3, bug #19986 (project lwip):

Simon.
     yes your fixed tcp.c work well.
     but i don't check the bounding problem,but I think it should work well.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #19986] tcp connect problem

Ondrej Lufinka

Update of bug #19986 (project lwip):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #4:

Thanks.
So I'll close this as fixed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19986>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel