[bug #54617] Compilation errors with LWIP_UDP=0

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #54617] Compilation errors with LWIP_UDP=0

Simon Goldschmidt
URL:
  <http://savannah.nongnu.org/bugs/?54617>

                 Summary: Compilation errors with LWIP_UDP=0
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: authmillenon
            Submitted on: Tue 04 Sep 2018 12:26:18 PM UTC
                Category: Network drivers
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

When trying to compile with UDP deactivated (<pre>#define LWIP_UDP 0</pre> in
lwipopts.h; to minimize binary size), I get several compilation errors in
current master as well as in STABLE-2_1_0_RC1:


src/netif/zepif.c: In function ‘zepif_linkoutput’:
src/netif/zepif.c:209:11: error: implicit declaration of function
‘udp_sendto’ [-Werror=implicit-function-declaration]
     err = udp_sendto(state->pcb, q, state->init.zep_dst_ip_addr,
state->init.zep_dst_udp_port);
           ^
src/netif/zepif.c: In function ‘zepif_init’:
src/netif/zepif.c:252:16: error: implicit declaration of function
‘udp_new_ip_type’ [-Werror=implicit-function-declaration]
   state->pcb = udp_new_ip_type(IPADDR_TYPE_ANY);
                ^
src/netif/zepif.c:252:14: error: assignment makes pointer from integer without
a cast [-Werror=int-conversion]
   state->pcb = udp_new_ip_type(IPADDR_TYPE_ANY);
              ^
src/netif/zepif.c:257:9: error: implicit declaration of function
‘udp_bind’ [-Werror=implicit-function-declaration]
   err = udp_bind(state->pcb, state->init.zep_src_ip_addr,
state->init.zep_src_udp_port);
         ^
src/netif/zepif.c:262:5: error: implicit declaration of function
‘udp_bind_netif’ [-Werror=implicit-function-declaration]
     udp_bind_netif(state->pcb, state->init.zep_netif);
[...]
src/include/lwip/ip.h:219:41: error: dereferencing pointer to incomplete type
‘struct udp_pcb’
 #define ip_set_option(pcb, opt)   ((pcb)->so_options =
(u8_t)((pcb)->so_options | (opt)))
                                         ^
src/netif/zepif.c:265:3: note: in expansion of macro ‘ip_set_option’
   ip_set_option(state->pcb, SOF_BROADCAST);
   ^
src/netif/zepif.c:266:3: error: implicit declaration of function
‘udp_recv’ [-Werror=implicit-function-declaration]
   udp_recv(state->pcb, zepif_udp_recv, netif);
   ^
src/netif/zepif.c:294:5: error: implicit declaration of function
‘udp_remove’ [-Werror=implicit-function-declaration]
     udp_remove(state->pcb);
     ^


This should be fixed with the attached patch (I hope this is the right way to
submit a patch... :-/).



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 04 Sep 2018 12:26:18 PM UTC  Name:
0001-Make-zepif-dependent-on-LWIP_UDP-config.patch  Size: 1KiB   By:
authmillenon

<http://savannah.nongnu.org/bugs/download.php?file_id=44932>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54617>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54617] Compilation errors with LWIP_UDP=0

Simon Goldschmidt
Update of bug #54617 (project lwip):

                  Status:                    None => Fixed                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                
         Planned Release:                    None => 2.1.0                  

    _______________________________________________________

Follow-up Comment #1:

Pushed, thanks for the patch!

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54617>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel