[bug #54669] while sending icmp_send_response , the iphdr_src is actual destination and iphdr_dst will become source, so it is swaped

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #54669] while sending icmp_send_response , the iphdr_src is actual destination and iphdr_dst will become source, so it is swaped

Simon Goldschmidt
URL:
  <https://savannah.nongnu.org/bugs/?54669>

                 Summary: while sending icmp_send_response , the iphdr_src is
actual destination and iphdr_dst will become source, so it is swaped
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: vineeshvinu
            Submitted on: Mon 17 Sep 2018 05:45:30 AM UTC
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

i have checked first ticket - 51593 and it is modified in below commit
60dd5188871eb2589ba000368e5cb0c05d27f89b. In this function icmp_send_response
, iphdr->src is should be the destination address for response and iphdr->dest
will be the source. ip4_route_src parameter may go wrong in this case because
in ip4_route_src the destination will become source and source will become
destination. please check once.




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54669>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54669] while sending icmp_send_response , the iphdr_src is actual destination and iphdr_dst will become source, so it is swaped

Simon Goldschmidt
Update of bug #54669 (project lwip):

                  Status:                    None => Fixed                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                
         Planned Release:                    None => 2.1.0                  

    _______________________________________________________

Follow-up Comment #1:

Right, fixed. Thanks for reporting!

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54669>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel