[bug #54749] 6Lo netif chooses wrong hardware address as destination

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #54749] 6Lo netif chooses wrong hardware address as destination

Simon Goldschmidt
URL:
  <https://savannah.nongnu.org/bugs/?54749>

                 Summary: 6Lo netif chooses wrong hardware address as
destination
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: authmillenon
            Submitted on: Fri 28 Sep 2018 08:51:44 AM UTC
                Category: Network drivers
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.1.0

    _______________________________________________________

Details:

First of all, congratulation for the release!

Sadly, I found a bug within the 6LoWPAN/6Lo code af the release when trying to
integrate it with RIOT :-( (find fix attached):

Since 3a8af61, when setting the destination address for a 6Lo device the
network interface's hardware address is set instead of the previously fetched
address from the neighbor cache.

Also mind that my fix technically isn't correct for IEEE 802.15.4, as mixed
address formats (e.g. source 16-bit, destination EUI-64) are possible, but
since nd6_get_next_hop_addr_or_queue() does not return any information about
the hardware address length, there is no way of getting the actual length of
the destination address (as far as I know). This is why I decided to just
revert the regression introduced 3a8af61, but to add a comment so this might
be fixed in the future.

Sorry that I didn't provide this fix during already for the release candidate.
I noticed something was wrong when testing it, but as always, time is short
and found it only now to properly pin-point the issue :-(.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 28 Sep 2018 08:51:44 AM UTC  Name:
0001-lowpan6.c-Fix-IEEE-802.15.4-address-setting.patch  Size: 1KiB   By:
authmillenon

<http://savannah.nongnu.org/bugs/download.php?file_id=45111>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54749>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54749] 6Lo netif chooses wrong hardware address as destination

Simon Goldschmidt
Update of bug #54749 (project lwip):

         Planned Release:                    None => 2.1.1                  

    _______________________________________________________

Follow-up Comment #1:

Sadly, this is what happens when people don't test release candidates ;-)

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54749>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54749] 6Lo netif chooses wrong hardware address as destination

Simon Goldschmidt
Follow-up Comment #2, bug #54749 (project lwip):

> Sadly, this is what happens when people don't test release candidates ;-)
_Nods sadly._

BTW the integration of lwIP v2.1.0 you can be found here:
https://github.com/RIOT-OS/RIOT/pull/10059

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54749>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54749] 6Lo netif chooses wrong hardware address as destination

Simon Goldschmidt
Follow-up Comment #3, bug #54749 (project lwip):

Oh, and I only tested for IEEE 802.15.4, but not for BLE (simply because there
is no glue-code for RIOT's BLE layer with lwIP yet). But as far as I can see,
it should work.


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54749>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54749] 6Lo netif chooses wrong hardware address as destination

Simon Goldschmidt
Update of bug #54749 (project lwip):

                  Status:                    None => Fixed                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #4:

As I don't have real 802.15.4 hardware to test, I'll just push it.

Thanks for testing.

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54749>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel