[bug #54833] tcp_abort(struct tcp_pcb *pcb) problem

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #54833] tcp_abort(struct tcp_pcb *pcb) problem

Simon Goldschmidt
URL:
  <https://savannah.nongnu.org/bugs/?54833>

                 Summary: tcp_abort(struct tcp_pcb *pcb) problem
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: dziegel
            Submitted on: Fri 12 Oct 2018 05:41:31 PM UTC
                Category: TCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: goldsimon
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.1.0

    _______________________________________________________

Details:

Hello,

There is a problem in tcp_abort function, when it is used with pcb in
"Active" state. The source port of RST packet sent is set to 0 .

In the previous version of LwIP in tcp_abandon function there was
variable "local_port". It was used to store the local port of pcb before
calling TCP_PCB_REMOVE_ACTIVE, and then it was passed as argument to
tcp_rst instead of pcb->local_port which is set to zero at this moment.

I don't know what was an idea to remove this variable from current
version of LwIP, but from my point of view it doesn't work properly now.

Regards

--
Karol Domagalski
Software-Hardware Engineer

B.P.I. SoftCad




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54833>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54833] tcp_abort(struct tcp_pcb *pcb) problem

Simon Goldschmidt
Update of bug #54833 (project lwip):

         Planned Release:                    None => 2.1.1                  

    _______________________________________________________

Follow-up Comment #1:

You're right it doesn't work. Don't know how that slipped through. This one is
now the most pressing to release a 2.1.1, I guess... :-(

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54833>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[bug #54833] tcp_abort(struct tcp_pcb *pcb) problem

Simon Goldschmidt
Update of bug #54833 (project lwip):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #2:

Fixed by reverting 1570dd8a

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?54833>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel