[patch #9699] the overflow check in tcp_recved is not correct

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9699] the overflow check in tcp_recved is not correct

Simon Goldschmidt
URL:
  <https://savannah.nongnu.org/patch/?9699>

                 Summary: the overflow check in tcp_recved is not correct
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: ghostav
            Submitted on: Wed 10 Oct 2018 10:44:57 PM UTC
                Category: TCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

A variable is overflowed if the result of the addition is smaller than its
previous value. The current implementation in tcp_received does this wrong by
simply comparing the result of the addition to 0.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 10 Oct 2018 10:44:57 PM UTC  Name:
0001-tcp_recved-check-for-overflow-and-warn-about-too-big.patch  Size: 2KiB  
By: ghostav

<http://savannah.nongnu.org/patch/download.php?file_id=45179>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9699>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9699] the overflow check in tcp_recved is not correct

Simon Goldschmidt
Update of patch #9699 (project lwip):

                  Status:                    None => Done                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #1:

Applied, thanks!

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9699>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9699] the overflow check in tcp_recved is not correct

Simon Goldschmidt
Follow-up Comment #2, patch #9699 (project lwip):

Fixed in a more generic way. Using assertions here was not a good idea,
unfortunately... :-(

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9699>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel