[patch #9815] ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h instead of deprecated mbedtls/net.h

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9815] ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h instead of deprecated mbedtls/net.h

Wilfred
URL:
  <https://savannah.nongnu.org/patch/?9815>

                 Summary: ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h
instead of deprecated mbedtls/net.h
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: giusloq
            Submitted on: Tue 11 Jun 2019 09:55:31 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

As mbedTLS git master source code says, mbedtls/net.h is deprecated. It is
included in alpc_tls_mbedtls.c.

In my project I replaced net.h with net_sockets.h without any problem. However
I don't sumbit a patch, because I don't know if there could be other
problems.





    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9815>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9815] ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h instead of deprecated mbedtls/net.h

Wilfred
Follow-up Comment #1, patch #9815 (project lwip):

But including net_sockets.h seems wrong: we're not using sockets?

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9815>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9815] ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h instead of deprecated mbedtls/net.h

Wilfred
Follow-up Comment #2, patch #9815 (project lwip):

If you look at mbedtls/net.h you will see that it actually includes
mbedtls/net_sockets.h. The only difference is that including net.h seems
deprecated.

Sincerely I don't know why they made net.h deprecated, maybe its name
conflicts in some building platforms.

Yes, lwip doesn't use sockets. However lwip actually uses some macros defined
in net.h/net_sockets.h, for example MBEDTLS_ERR_NET_CONN_RESET.

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9815>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel