[patch #9844] Sockets: Unit tests and apps corrections

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9844] Sockets: Unit tests and apps corrections

David GIRAULT-2
URL:
  <https://savannah.nongnu.org/patch/?9844>

                 Summary: Sockets: Unit tests and apps corrections
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jllledo
            Submitted on: Sat 10 Aug 2019 12:12:10 PM CEST
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

1.- src/apps/lwiperf/lwiperf.c:
  - Line 773: Calls htonl() but lwip/inet.h is not included
  - There are other apps and unit tests where htons and pals are being called
w/o
    including lwip/inet.h

2.- test/unit/api/test_sockets.c:
  - Line 156: write() could be declared by external socket headers. Call
lwip_write()
    instead.
  - Line 333: it expects fcntl() to return 6, but O_RDWR could have another
value if
    external socket headers are present. Replace 6 by O_RDWR.

3.- apps/tftp/tftp.c: recv() could be declared by external socket headers.
Rename it to
    tftp_recv()
  - Lines 243 and 471

More info at:

https://lists.nongnu.org/archive/html/lwip-devel/2019-07/msg00001.html



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 10 Aug 2019 12:12:10 PM CEST  Name:
0002-Sockets-Unit-tests-and-apps-corrections.patch  Size: 4KiB   By: jllledo

<http://savannah.nongnu.org/patch/download.php?file_id=47318>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9844>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9844] Sockets: Unit tests and apps corrections

David GIRAULT-2
Update of patch #9844 (project lwip):

                  Status:                    None => Done                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #1:

Applied, thanks for the patch.

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9844>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel