[patch #9847] Fixes in IPv4 autoip

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[patch #9847] Fixes in IPv4 autoip

David GIRAULT-2
URL:
  <https://savannah.nongnu.org/patch/?9847>

                 Summary: Fixes in IPv4 autoip
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: sathishm6
            Submitted on: Wed 28 Aug 2019 04:54:50 AM UTC
                Category: IPv4
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

This patch fixes following issues in autoip.
  1) Corrected the condition for limiting the probe interval to match RFC
3927, Section 2.2.1.
  2) Added fixes in autoip_stop() to avoid memory leak during autoip_start()
-> autoip_stop() sequence.

Additional Details:
  1. Fixed bug in max conflict rate limiting.
      - According to RFC section RFC 3927 Section 2.2.1 conflict probe
interval
        should be increased to RATE_LIMIT_INTERVAL (60 seconds), after
conflict count reaches
        MAX_CONFLICTS (i.e., 10) counts.
      - The initial value of 'autoip->tried_llipaddr' is 0. Hence the probe
        interval (i.e., autoip->ttw) should be increased to
RATE_LIMIT_INTERVAL (60 secs)
        when the condition becomes 'autoip->tried_llipaddr >= MAX_CONFLICTS'

  2. Added code to free 'autoip' client in autoip_stop() API.
      - 'autoip' client is allocated in autoip_start() API, this client is
not
        freed during autoip_stop() or in any other part of the code.
      - Updated autoip_stop() API to release the memory allocated for 'autoip'
client during start.

Tag used as a base revision to apply the fix: : STABLE-2_1_2_RELEASE




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 28 Aug 2019 04:54:50 AM UTC  Name: autoip_fix.patch  Size: 3KiB  
By: sathishm6
Patch file with autoip fixes
<http://savannah.nongnu.org/patch/download.php?file_id=47402>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9847>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel