[patch #9883] Fix typos using codespell

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9883] Fix typos using codespell

Simon Goldschmidt
URL:
  <https://savannah.nongnu.org/patch/?9883>

                 Summary: Fix typos using codespell
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jona
            Submitted on: Mon 06 Jan 2020 11:21:59 PM UTC
                Category: None
                Priority: 3 - Low
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

The next step to avoid typo can be to provide a script like for RIOT:
https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/codespell/check.sh



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 06 Jan 2020 11:21:59 PM UTC  Name:
0001-Fix-typos-using-codespell.patch  Size: 293KiB   By: jona

<http://savannah.nongnu.org/patch/download.php?file_id=48174>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9883>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9883] Fix typos using codespell

Simon Goldschmidt
Follow-up Comment #1, patch #9883 (project lwip):

Nice patch. However:
- MIBs are imported documents, we cannot just change them
- unix example_app Makefile is completely changed

Instead of applying this patch, I would rather commit a "check.sh" script
doing everything right and then just committing its changes.

Is this patch an output of such a script? If so, could you post it here?

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9883>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[patch #9883] Fix typos using codespell

Simon Goldschmidt
Follow-up Comment #2, patch #9883 (project lwip):

Here is another review of the idea.

First patch "Add codespell wrappers ..." are the two scripts you asked.
Second patch "Fix typos ..." is an updated version considering your remarks
(sorry for the Makefile, it was a little bit late).

If you want a fast check, you can try with : "codespell -q 2
--ignore-words-list=nd,ans,tolen,ofo,wan -i1 $(git ls-tree -r --full-tree
--name-only HEAD | grep -E '\.([CcHh])$')" (-i1 discard multiple choices)
or
"codespell -q 2 --ignore-words-list=nd,ans,tolen,ofo,wan,mut -i3 $(git ls-tree
-r --full-tree --name-only HEAD | grep -E '\.([CcHh])$')" (it ask for input
over multiple choices)
The two scripts here are dry-run version (-w to write to files).

(file #48225, file #48226)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-Add-codespell-wrappers-check.sh-changed_files.sh.patch Size:3
KB
   
<https://savannah.nongnu.org/file/0001-Add-codespell-wrappers-check.sh-changed_files.sh.patch?file_id=48225>

File name: 0001-Fix-typos-using-codespell.patch Size:47 KB
   
<https://savannah.nongnu.org/file/0001-Fix-typos-using-codespell.patch?file_id=48226>



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9883>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel