[task #14798] PPP log messages

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP log messages

Simon Goldschmidt
URL:
  <http://savannah.nongnu.org/task/?14798>

                 Summary: PPP log messages
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: marcoe
            Submitted on: Thu 04 Jan 2018 03:27:27 PM UTC
                Category: PPP
         Should Start On: Thu 04 Jan 2018 12:00:00 AM UTC
   Should be Finished on: Thu 04 Jan 2018 12:00:00 AM UTC
                Priority: 3 - Low
                  Status: None
                 Privacy: Public
        Percent Complete: 0%
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
                  Effort: 1.00

    _______________________________________________________

Details:

Hello all,
I've noticed that also with PPP_DEBUG = 0 some kiloBytes of flash memory are
occupied by ppp_vslprintf() code and by many PPP debug strings.

In fact, debugging messages are not consistent across PPP code because:
- in some points log messages are correctly produced using macros like
LCPDEBUG(a) defined in pppdebug.h
- in other points there are direct calls to ppp_warn(), ppp_notice(), ...
- in other points the calls to ppp_warn(), ppp_notice(), ... are inside a #if
PPP_DEBUG ... #endif block

I think it would be nice to have the possibility to completely remove these
log messages and related helper functions in a production environment as well
as we can do it for all the other debug messages inside lwIP.

Bye




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP log messages

Simon Goldschmidt
Follow-up Comment #1, task #14798 (project lwip):

If this should be a task, you should have given it a summary that tells us
what to do. "PPP log messages" is not a task. Do you think it's a bug that
28th PPP debug disabled, too many things are linked in? If so, a bug report
would have been better.

Which version of lwip are you talking about anyway?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP log messages

Simon Goldschmidt
Follow-up Comment #2, task #14798 (project lwip):

I was thinking it could be an enhancement and, as a consequence, that a task
was needed to proceed with a little cleanup of this part of code. Sorry if
this is not the intended meaning for "task". I don't think this is a bug
because as far as I know PPP is fully working, also if not size-optimized. If
you prefer to have a bug report instead I will close here and open a bug
report, tell me how to proceed.

In any case, I'm using lwIP 2.0.3 release version
(92f23d6ca0971a32f2085b9480e738d34174417b).


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP log messages

Simon Goldschmidt
Follow-up Comment #3, task #14798 (project lwip):

Ok, a task is fine then. But it needs a summary that tells us what to do when
viewing the task list.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP log messages

Simon Goldschmidt
Follow-up Comment #4, task #14798 (project lwip):

Ok, the summary could become "PPP: improve PPP_DEBUG macro support (now it
doesn't suppress all PPP debug messages)".

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP: improve PPP_DEBUG macro support

Simon Goldschmidt
Update of task #14798 (project lwip):

                 Summary:        PPP log messages => PPP: improve PPP_DEBUG
macro support


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP: improve PPP_DEBUG macro support

Simon Goldschmidt
Follow-up Comment #5, task #14798 (project lwip):

I've attached a suggestion that ensures the output code is only compiled in if
enabled.

Since that requires changing all callers to call e.g. 'ppp_info(("msg"))'
instead of 'ppp_info("msg")': Sylvain, are you ok with this?

(file #48113)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-ppp-improve-PPP_DEBUG-macro-support.patch Size:3 KB
   
<https://savannah.nongnu.org/file/0001-ppp-improve-PPP_DEBUG-macro-support.patch?file_id=48113>



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP: improve PPP_DEBUG macro support

Simon Goldschmidt
Update of task #14798 (project lwip):

                  Status:                    None => Done                  
        Percent Complete:                      0% => 100%                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #6:

Pushed after lack of response... ;-) Sylvain: feel free to revert if it doesn'
fit

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #14798] PPP: improve PPP_DEBUG macro support

Simon Goldschmidt
Follow-up Comment #7, task #14798 (project lwip):

Pushed after lack of response... ;-) Sylvain: feel free to revert if it doesn'
fit

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?14798>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/lwip-devel