Summary: PPP log messages
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: marcoe
Submitted on: Thu 04 Jan 2018 03:27:27 PM UTC
Should Start On: Thu 04 Jan 2018 12:00:00 AM UTC
Should be Finished on: Thu 04 Jan 2018 12:00:00 AM UTC
Priority: 3 - Low
Percent Complete: 0%
Assigned to: None
Discussion Lock: Any
Planned Release: None
I've noticed that also with PPP_DEBUG = 0 some kiloBytes of flash memory are
occupied by ppp_vslprintf() code and by many PPP debug strings.
In fact, debugging messages are not consistent across PPP code because:
- in some points log messages are correctly produced using macros like
LCPDEBUG(a) defined in pppdebug.h
- in other points there are direct calls to ppp_warn(), ppp_notice(), ...
- in other points the calls to ppp_warn(), ppp_notice(), ... are inside a #if
PPP_DEBUG ... #endif block
I think it would be nice to have the possibility to completely remove these
log messages and related helper functions in a production environment as well
as we can do it for all the other debug messages inside lwIP.
If this should be a task, you should have given it a summary that tells us
what to do. "PPP log messages" is not a task. Do you think it's a bug that
28th PPP debug disabled, too many things are linked in? If so, a bug report
would have been better.
Which version of lwip are you talking about anyway?
I was thinking it could be an enhancement and, as a consequence, that a task
was needed to proceed with a little cleanup of this part of code. Sorry if
this is not the intended meaning for "task". I don't think this is a bug
because as far as I know PPP is fully working, also if not size-optimized. If
you prefer to have a bug report instead I will close here and open a bug
report, tell me how to proceed.
In any case, I'm using lwIP 2.0.3 release version