[task #7360] Move ethernet_input to etharp.c

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[task #7360] Move ethernet_input to etharp.c

David GIRAULT-2

URL:
  <http://savannah.nongnu.org/task/?7360>

                 Summary: Move ethernet_input to etharp.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Donnerstag 04.10.2007 um 18:11
                Category: None
         Should Start On: Donnerstag 04.10.2007 um 00:00
   Should be Finished on: Donnerstag 04.10.2007 um 00:00
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
        Percent Complete: 0%
             Assigned to: goldsimon
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
                  Effort: 0.00

    _______________________________________________________

Details:

Anyone against moving the function ethernet_input() from tcpip.c into
etharp.c? (The function splitting an incoming ethernet packet based on its
protocol - IP/ARP/PPPOE)

It seems to fit best there since I also need it in the msvc6 port with
NOSYS=1, and the current place in tcpip.c doesn't seem right with that
configuration (since the whole code in tcpip.c is ifdef'ed with NO_SYS=0, and
I normally don't build tcpip.c with NO_SYS=1).




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #7360] Move ethernet_input to etharp.c

David GIRAULT-2

Follow-up Comment #1, task #7360 (project lwip):

ok for me

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

RE: [task #7360] Move ethernet_input to etharp.c

Grubb, Jared
In reply to this post by David GIRAULT-2
Fine with me!

-----Original Message-----
From: lwip-devel-bounces+jgrubb=[hidden email] [mailto:lwip-devel-bounces+jgrubb=[hidden email]] On Behalf Of Simon Goldschmidt
Sent: Thursday, October 04, 2007 11:11 AM
To: Simon Goldschmidt; [hidden email]
Subject: [lwip-devel] [task #7360] Move ethernet_input to etharp.c


URL:
  <http://savannah.nongnu.org/task/?7360>

                 Summary: Move ethernet_input to etharp.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Donnerstag 04.10.2007 um 18:11
                Category: None
         Should Start On: Donnerstag 04.10.2007 um 00:00
   Should be Finished on: Donnerstag 04.10.2007 um 00:00
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
        Percent Complete: 0%
             Assigned to: goldsimon
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
                  Effort: 0.00

    _______________________________________________________

Details:

Anyone against moving the function ethernet_input() from tcpip.c into
etharp.c? (The function splitting an incoming ethernet packet based on its
protocol - IP/ARP/PPPOE)

It seems to fit best there since I also need it in the msvc6 port with
NOSYS=1, and the current place in tcpip.c doesn't seem right with that
configuration (since the whole code in tcpip.c is ifdef'ed with NO_SYS=0, and
I normally don't build tcpip.c with NO_SYS=1).




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel

_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #7360] Move ethernet_input to etharp.c

David GIRAULT-2
In reply to this post by David GIRAULT-2

Update of task #7360 (project lwip):

                  Status:                    None => Done                  
        Percent Complete:                      0% => 100%                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #2:

OK, done. I'll update the msvc port to use it. BTW: the unix port still calls
etharp_arp_input directly, which is not thread-safe. Do we have a port
maintainer for this or why is this in 'ports', not in 'old'?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: [task #7360] Move ethernet_input to etharp.c

Kieran Mansley
On Fri, 2007-10-05 at 14:03 +0000, Simon Goldschmidt wrote:

> Update of task #7360 (project lwip):
>
>                   Status:                    None => Done                  
>         Percent Complete:                      0% => 100%                  
>              Open/Closed:                    Open => Closed                
>
>     _______________________________________________________
>
> Follow-up Comment #2:
>
> OK, done. I'll update the msvc port to use it. BTW: the unix port still calls
> etharp_arp_input directly, which is not thread-safe. Do we have a port
> maintainer for this or why is this in 'ports', not in 'old'?

Largely because it's the de-facto reference port, and so needed to be
kept up to date.  I think I might have said I would try and maintain it,
but I'm clearly failing to find the free time.  If anyone can help bring
it up to date that would be most welcome.

Kieran



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #7360] Move ethernet_input to etharp.c

David GIRAULT-2
In reply to this post by David GIRAULT-2

Follow-up Comment #3, task #7360 (project lwip):

I don't think there is a real port maintainer for unix port, but I'm agree to
move it in "old" if noone want to take this role.

Else, I'm in flavor to rename "ethernet_input" in "etharp_input" to be
coherent with other etharp functions, and since there is already
"etharp_ip_input" and "etharp_arp_input".

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

[task #7360] Move ethernet_input to etharp.c

David GIRAULT-2

Follow-up Comment #4, task #7360 (project lwip):

We could even remove etharp_ip_input and etharp_arp_input from etharp.h since
they are(should) not directly call be other modules...

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7360>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/



_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel
Reply | Threaded
Open this post in threaded view
|

Re: [task #7360] Move ethernet_input to etharp.c

goldsimon@gmx.de
In reply to this post by Kieran Mansley

> Largely because it's the de-facto reference port, and so needed to be
> kept up to date.  I think I might have said I would try and maintain it,
> but I'm clearly failing to find the free time.  If anyone can help bring
> it up to date that would be most welcome.
>  
The de-facto reference port, huh? Seems like there is some work to do
before 1.3.0, hehe ;-)
I'll see what I can do, although I don't really use it... Maybe some
consistency with the msvc port
(especially moving the app files into conrtib/apps) would be good before
releasing.

Simon


_______________________________________________
lwip-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/lwip-devel